[Accepted] [TW] Mix Weapon Type Transmog

User avatar
slocraft
Posts: 12
Joined: 22 Dec 2013 14:56

Re: [TW] Mix Weapon Type Transmog

#61 » Post by slocraft » 02 Oct 2016 16:28

well I vote yes for it. But I'm not sure about one thing. want to sort it out :D
So you will able to transmog your weapon into something other, that you OWN or OWN and have already equipped?
Long Live Rock'n'Roll
\m/ UNDYABLE \m/

User avatar
Gadoschi
Donor
Posts: 222
Joined: 27 Feb 2015 19:44
Location: Croatia

Re: [TW] Mix Weapon Type Transmog

#62 » Post by Gadoschi » 02 Oct 2016 16:41

No. You do not have to have equipped it.

But you will have to BE ABLE TO USE it.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm

User avatar
slocraft
Posts: 12
Joined: 22 Dec 2013 14:56

Re: [TW] Mix Weapon Type Transmog

#63 » Post by slocraft » 02 Oct 2016 16:50

So basically if I have a BoE item I can trade it endlessly to my friends and let them get the mog? or u actually have to have it in your bag for mog to work? :D
Long Live Rock'n'Roll
\m/ UNDYABLE \m/

User avatar
Matsy
Posts: 1244
Joined: 28 Aug 2010 19:17
Location: United Kingdom

Re: [TW] Mix Weapon Type Transmog

#64 » Post by Matsy » 02 Oct 2016 16:59

slocraft wrote:So basically if I have a BoE item I can trade it endlessly to my friends and let them get the mog? or u actually have to have it in your bag for mog to work? :D
No.
Think his wording alittle odd.
You have to be able to equip the weapon and have it binded to yourself (equip BoE items)
Matsy pls
Mats - Frost PVE Troll Death Knight - Retired
Matsy - Moonkin/Restoration Druid (Laz0r Chicken)
Mat - Marksman Troll Hunter
Matz -Retribution Paladin
Matu - Troll Shadow Priest
Bolts - Elemental Troll Shaman
Kungfu - Orc Fury Warrior
Trollage - Troll Arcane Mage
Mato - Orc Affliction Warlock
Findme - Troll Assassination Rogue

I Pity the Fool who's illogical
Friends are just people you hate the least
I reject your reality and substitute my own

User avatar
Wilcox
Posts: 1587
Joined: 16 Dec 2012 13:37
Location: Kebabland

Re: [TW] Mix Weapon Type Transmog

#65 » Post by Wilcox » 03 Oct 2016 08:09

item has to be soulbound, and something you can wear, simple logic

User avatar
Nyeriah

Re: [TW] Mix Weapon Type Transmog

#66 » Post by Nyeriah » 12 Oct 2016 02:34

Pending, very, very, very low priority atm

User avatar
Gnurg
Posts: 2394
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: [Pending] Mix Weapon Type Transmog

#67 » Post by Gnurg » 07 Nov 2016 13:51

There was a thank you note to Rochet2 on our Transmog FAQ page, so I took a look Rochet2's source code and they had the "curious" allow mixed weapon future. I am guessing that this is the source code used for our transmog.

The problem with the "allowMixedWeapon" future is that you can mix some weapons that shouldn't be mixable. To fix the problem, we have to some extra logic towards the end of this function.

First we need some weapons pools. They already had the IsRangedWeapon method.

We need one for OneHandedWeapons

Code: Select all

bool Transmogrification::IsOneHandedWeapon(uint32 Class, uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsOneHandedWeapon");

return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_AXE ||
SubClass == ITEM_SUBCLASS_WEAPON_MACE ||
SubClass == ITEM_SUBCLASS_WEAPON_SWORD);
}
and TwoHandedWeapons.

Code: Select all

bool Transmogrification::IsTwoHandedWeapon(uint32 Class, uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsTwoHandedWeapon");

return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_AXE2 ||
SubClass == ITEM_SUBCLASS_WEAPON_MACE2 ||
SubClass == ITEM_SUBCLASS_WEAPON_SWORD2 ||
SubClass == ITEM_SUBCLASS_WEAPON_STAFF ||
SubClass == ITEM_SUBCLASS_WEAPON_POLEARM);
}
To allow main hand dagger (otherwise known as caster dagger) to be transmogged into a OneHandedWeapon, I added a method to check if the weapon is a main hand dagger.

Code: Select all

bool Transmogrification::IsMainHandDagger(ItemTemplate const* item) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsMainHandDagger");

return item->Class == ITEM_CLASS_WEAPON && item->InventoryType == INVTYPE_WEAPONMAINHAND && item->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER;
}
Finally, we need to make sure the rest of the weapons that don't belong in any of these weapon pools can't be the source for other weapons.

Code: Select all

bool Transmogrification::BadWeaponSource(uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::BadWeaponSource");

return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_FIST_WEAPON ||
SubClass == ITEM_SUBCLASS_WEAPON_DAGGER ||
SubClass == ITEM_SUBCLASS_WEAPON_THROWN ||
SubClass == ITEM_SUBCLASS_WEAPON_SPEAR ||
SubClass == ITEM_SUBCLASS_WEAPON_WAND ||
SubClass == ITEM_SUBCLASS_WEAPON_FISHING_POLE);
}
Now we only have to update this part with the new functions to make it work.

Code: Select all

 if (source->InventoryType != target->InventoryType || (AllowMixedArmorTypes && source->Class == ITEM_CLASS_WEAPON))
{
if (source->Class == ITEM_CLASS_WEAPON &&
(IsRangedWeapon(target->Class, target->SubClass) != IsRangedWeapon(source->Class, source->SubClass) ||
IsTwoHandedWeapon(target->Class, target->SubClass) != IsTwoHandedWeapon(source->Class, source->SubClass) ||
(IsOneHandedWeapon(target->Class, target->SubClass) != IsOneHandedWeapon(source->Class, source->SubClass) && !IsMainHandDagger(target)) ||
source->InventoryType == INVTYPE_WEAPONMAINHAND ||
source->InventoryType == INVTYPE_WEAPONOFFHAND ||
BadWeaponSource(source->SubClass)))
return false;
if (source->Class == ITEM_CLASS_ARMOR &&
!((source->InventoryType == INVTYPE_CHEST && target->InventoryType == INVTYPE_ROBE) ||
(source->InventoryType == INVTYPE_ROBE && target->InventoryType == INVTYPE_CHEST)))
return false;
}
Could we give this a try on the PTR? :-)
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Ratmout
Donor
Posts: 37
Joined: 27 Dec 2013 05:25

Re: [Pending] Mix Weapon Type Transmog

#68 » Post by Ratmout » 10 Nov 2016 08:10

Give it a try plz!!

User avatar
Gadoschi
Donor
Posts: 222
Joined: 27 Feb 2015 19:44
Location: Croatia

Re: [TW] Mix Weapon Type Transmog

#69 » Post by Gadoschi » 10 Nov 2016 19:01

Nyeriah wrote:Pending, very, very, very low priority atm
Shouldn't priorities be set by what the community wants?

And judging by the ammount of activity in this thread compared to other threads and the ammount of transmog hunters out there in the server, I would say that transmog is currently very high on community's list of wanted upgrades/updates/fixes.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm

User avatar
Gnurg
Posts: 2394
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: [TW] Mix Weapon Type Transmog

#70 » Post by Gnurg » 10 Nov 2016 19:07

Gadoschi wrote:
Nyeriah wrote:Pending, very, very, very low priority atm
Shouldn't priorities be set by what the community wants?

And judging by the ammount of activity in this thread compared to other threads and the ammount of transmog hunters out there in the server, I would say that transmog is currently very high on community's list of wanted upgrades/updates/fixes.
I am already working on this and it's soon to be released, should I manage to fix the few issues left.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Gadoschi
Donor
Posts: 222
Joined: 27 Feb 2015 19:44
Location: Croatia

Re: [Pending] Mix Weapon Type Transmog

#71 » Post by Gadoschi » 10 Nov 2016 19:08

That's great news.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm

User avatar
Gnurg
Posts: 2394
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: [Pending] Mix Weapon Type Transmog

#72 » Post by Gnurg » 10 Nov 2016 20:15

It's enabled on the PTR now, so if you want to help me debug, please do.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Gadoschi
Donor
Posts: 222
Joined: 27 Feb 2015 19:44
Location: Croatia

Re: [Pending] Mix Weapon Type Transmog

#73 » Post by Gadoschi » 10 Nov 2016 21:16

What are the bugs concerning?
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm

User avatar
Gnurg
Posts: 2394
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: [Pending] Mix Weapon Type Transmog

#74 » Post by Gnurg » 10 Nov 2016 21:26

Gadoschi wrote:What are the bugs concerning?
If you can switch within a weapon pool and can't go beyond the weapon pool. As well as check items not in weapon pools.

It seemed fine when I tested it, besides legendaries, but I think that's just some configuration setting difference between PTR and TW.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Gnurg
Posts: 2394
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: [Pending] Mix Weapon Type Transmog

#75 » Post by Gnurg » 17 Nov 2016 13:42

This is now enabled for the TrueWoW realm.

[hide]Pool 1: Ranged Weapons (Already existing)
  • Gun
  • Bow
  • Crossbow
Pool 2: Two-Handed Weapons (Staff and Poleaxe should not be included due to dual wielding fury staff/poleaxe warrior)
  • Two-Handed Axe
  • Two-Handed Mace
  • Two-Handed Sword
  • Polearm
  • Staff
Pool 3: One-Handed Weapons
  • Axe
  • Mace
  • Sword
  • Main-Hand Dagger to the others, but not others to Main-Hand Dagger
[/hide]

If you find any bugs (i.e. illegal transmogs), please notify through PM so I can look into it.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

Locked

Who is online

Users browsing this forum: No registered users and 3 guests