[Accepted] Remove the Sale Pending message and lower the time for items to arrive

User avatar
Gnurg
Posts: 2420
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

[Accepted] Remove the Sale Pending message and lower the time for items to arrive

#1 » Post by Gnurg » 11 Dec 2016 16:48

There's no reason for us to wait 1 hour to receive the money from a successful auction. Could we lower the 1 hour to no time or just a few minutes? Should the delay be reduced, the Sale Pending message becomes less useful. Right now, this message isn't removed after the time expires, so it's pretty much just annoying for the player rather than useful. I suggest just removing it.

Changing this is a matter of commenting out one line and changing one config value. Very straightforward and easy.

1. Lower the time for the auction money to arrive. :tick:
2. Remove the Sale Pending message. :tick:

Please give me your opinions.
Last edited by Gnurg on 13 Dec 2016 20:38, edited 2 times in total.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
MerelyASetback
Donor
Posts: 110
Joined: 07 Aug 2013 23:49

Re: Remove the Sale Pending message and lower the time for items to arrive

#2 » Post by MerelyASetback » 11 Dec 2016 17:03

Just remove the delay and pending mail. There's no real use for it here.

Unless TW actually monitors for 'shady' 'goldselly' transactions or it's a strain on the server somehow.


User avatar
Eronox
MVP
Posts: 2331
Joined: 24 Apr 2016 11:03
Location: in ICC & Healing

Re: Remove the Sale Pending message and lower the time for items to arrive

#4 » Post by Eronox » 11 Dec 2016 18:59

Fastor wrote:+1
+1
He used my +1
.

There's things that never will be right I know, and things need changin' everywhere you go.
But 'til we start to make a move to make a few things right,
You'll never see me wear a suit of white.

- J.R Cash


User avatar
Fastor
Posts: 4031
Joined: 16 Dec 2012 17:38

Re: Remove the Sale Pending message and lower the time for items to arrive

#5 » Post by Fastor » 11 Dec 2016 19:12

Actually that was +1 per suggestion since it seems separate. However, this seems not Blizzlike so l doubt this will pass. Relina posted on some topic about how this came Live on patch 2.2.0 but our mail system suck and does not delete (nor calculate time in) message.

But anyway, have some

Code: Select all

+1

User avatar
Royo
Posts: 248
Joined: 14 Dec 2014 23:43

Re: Remove the Sale Pending message and lower the time for items to arrive

#6 » Post by Royo » 11 Dec 2016 19:17

+1

User avatar
warangels
Posts: 91
Joined: 17 May 2016 01:01

Re: Remove the Sale Pending message and lower the time for items to arrive

#7 » Post by warangels » 11 Dec 2016 20:18

Fastor wrote:Actually that was +1 per suggestion since it seems separate. However, this seems not Blizzlike so l doubt this will pass. Relina posted on some topic about how this came Live on patch 2.2.0 but our mail system suck and does not delete (nor calculate time in) message.

But anyway, have some

Code: Select all

+1
+1

User avatar
Gnurg
Posts: 2420
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: Remove the Sale Pending message and lower the time for items to arrive

#8 » Post by Gnurg » 12 Dec 2016 00:27

The Sale Pending Mail will be disabled on next update.

Will need someone with access to modify the delay time, should we decide on lowering it.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Nyeriah

Re: Remove the Sale Pending message and lower the time for items to arrive

#9 » Post by Nyeriah » 13 Dec 2016 04:27

Gnurg wrote:The Sale Pending Mail will be disabled on next update.

Will need someone with access to modify the delay time, should we decide on lowering it.
I don't see such a setting in the config file. Could you show me?

I only see
#
# MailDeliveryDelay
# Description: Time (in seconds) mail delivery is delayed when sending items.
# Default: 3600 - (1 hour)

MailDeliveryDelay = 3600
Which is not something we'd probably want to change

User avatar
Gnurg
Posts: 2420
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: Remove the Sale Pending message and lower the time for items to arrive

#10 » Post by Gnurg » 13 Dec 2016 10:11

Nyeriah wrote:
Gnurg wrote:The Sale Pending Mail will be disabled on next update.

Will need someone with access to modify the delay time, should we decide on lowering it.
I don't see such a setting in the config file. Could you show me?

I only see
#
# MailDeliveryDelay
# Description: Time (in seconds) mail delivery is delayed when sending items.
# Default: 3600 - (1 hour)

MailDeliveryDelay = 3600
Which is not something we'd probably want to change
That's the one they use for auction, though it might be used elsewhere as well.

https://github.com/TrinityCore/TrinityC ... r.cpp#L185 Alternatively, you could make a new setting they retrieve from or hardcode it.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
kronic
Posts: 190
Joined: 18 Aug 2015 16:25

Re: Remove the Sale Pending message and lower the time for items to arrive

#11 » Post by kronic » 13 Dec 2016 10:32

Oh lord please +1

User avatar
Gnurg
Posts: 2420
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: Remove the Sale Pending message and lower the time for items to arrive

#12 » Post by Gnurg » 13 Dec 2016 11:25

Gnurg wrote:
Nyeriah wrote:
Gnurg wrote:The Sale Pending Mail will be disabled on next update.

Will need someone with access to modify the delay time, should we decide on lowering it.
I don't see such a setting in the config file. Could you show me?

I only see
#
# MailDeliveryDelay
# Description: Time (in seconds) mail delivery is delayed when sending items.
# Default: 3600 - (1 hour)

MailDeliveryDelay = 3600
Which is not something we'd probably want to change
That's the one they use for auction, though it might be used elsewhere as well.

https://github.com/TrinityCore/TrinityC ... r.cpp#L185 Alternatively, you could make a new setting they retrieve from or hardcode it.
The only other place it is in use, is when sending a mail to another player. Do we need the delay there? I would say no, it creates less unecesarry hassle. Imo set it to 60 seconds and it should be good.

https://github.com/TrinityCore/TrinityC ... r.cpp#L321
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Nyeriah

Re: Remove the Sale Pending message and lower the time for items to arrive

#13 » Post by Nyeriah » 13 Dec 2016 12:29

I don't really like the idea of deconstructing everything for convenience. There are a lot of inconvenient things that are there for no reason but being part of the game.

User avatar
Gnurg
Posts: 2420
Joined: 28 Jan 2013 19:38
Location: Oslo, Norway

Re: Remove the Sale Pending message and lower the time for items to arrive

#14 » Post by Gnurg » 13 Dec 2016 12:37

Nyeriah wrote:I don't really like the idea of deconstructing everything for convenience. There are a lot of inconvenient things that are there for no reason but being part of the game.
You can get around the mail delivery time by trading anyways, as you can have as many accounts as you wish for no further cost, unlike on retail. It's just a bit more time consuming.

If you were in favour of reducing auction house time, but don't want to alter the cross-account mail delay, we could always make it retrieve the value from a new config setting.

Quickly reading up on the delay, they use the 1 hour to ensure that the money doesn't originate from shady gold sellers and to prevent the gold from spreading too fast. If there's algorithm in place to detect that on mails, the delay serves no purpose.
HAI
CAN HAZ STDIO?
VISIBLE "HAI WORLD, IZ GNURF!"
KTHXBYE

User avatar
Garadan
Posts: 30
Joined: 12 Mar 2014 23:54

Re: Remove the Sale Pending message and lower the time for items to arrive

#15 » Post by Garadan » 13 Dec 2016 14:34

Fuck off with these minor changes, spamming forums with your dumb ideas to get everything easier

I'm waiting for your reply here : http://www.truewow.org/forum/viewtopic. ... &start=105
Garadan from Garadar.

Locked

Who is online

Users browsing this forum: No registered users and 1 guest