Teleport to Nearest Controlled Graveyard BG Command

[Gnurg]

Back on Bloodcraft we had the function .st (stuck, I guess), which would teleport you the nearest graveyard. It might have worked outside battlegrounds, but I used it primarily for when I wasn't teleported to a new GY when someone stole your graveyard (which happens here sometimes).

I would rename it to .gy (graveyard)

Syntax would just be .gy and the result would be:
1. Check if player is dead and is in a battleground. If not, do nothing and give user feedback.
2. Teleport player to nearest graveyard.

I've tested the command handler below locally, and it works according to what I wrote above.

Code: Select all

static bool HandleGraveyardCommand(ChatHandler* handler, char const* /* args */ )

{

	

	Player* player = handler->GetSession()->GetPlayer();

	if (!player)

		return false;



	if (!player->InBattleground()) {	

		handler->SendSysMessage("Graveyard can only be used in battlegrounds.");

		handler->SetSentErrorMessage(true);

		return false;

	}

	

	if (!player->isDead()) {

		handler->SendSysMessage("Graveyard can only be used while dead.");

		handler->SetSentErrorMessage(true);

		return false;

	}

	

	if (Battleground * bg = player->GetBattleground()) {

		if (WorldSafeLocsEntry const* closestGrave = bg->GetClosestGraveYard(player)) {

			player->TeleportTo(bg->GetMapId(), closestGrave->x, closestGrave->y, closestGrave->z, player->GetOrientation());

		}

	}

	

	return true;

}

[Eronox]

+1

[benzviliran]

-1 this is not how it should be, players should not be able to teleport to nearest graveyard that will result in many abuses both in bgs and outside bgs.

[Fastor]

Add check is user dead.
+1

[Longi]

I thought that the server has done this automatically I mean move a player to nearest controlled graveyard if your team lost one where you are waiting for respawn. I think it was working on GC like this

[Gnurg]

-1 this is not how it should be, players should not be able to teleport to nearest graveyard that will result in many abuses both in bgs and outside bgs.

I see now that I forgot to mention that the player should be dead. Thought it was kind of obvious when it came to the graveyard stealing part, but whatever, updating first post.

It's to counter the bug that when someone captures the graveyard you get placed at, you don't get teleported to a new graveyard, which to me seems to happen if it gets captured just as you get teleported there. You end up having to walk to the next graveyard in ghost-form.

I did state in the first topic that it should only work inside battleground, so outside battlegrounds shouldn't be a problem, which you'd know if you read the post (even just the title in this case).

[benzviliran]

-1 this is not how it should be, players should not be able to teleport to nearest graveyard that will result in many abuses both in bgs and outside bgs.

I see now that I forgot to mention that the player should be dead. Thought it was kind of obvious when it came to the graveyard stealing part, but whatever, updating first post.

It's to counter the bug that when someone captures the graveyard you get placed at, you don't get teleported to a new graveyard, which to me seems to happen if it gets captured just as you get teleported there. You end up having to walk to the next graveyard in ghost-form.

I did state in the first topic that it should only work inside battleground, so outside battlegrounds shouldn't be a problem, which you'd know if you read the post (even just the title in this case).

again it can be abused in bgs and outside bgs.

[kermo14k]

How can it be abused? You are dead, opposite faction steals your graveyard, instead of getting automatically(how it should be) teleported to the nearest graveyard your faction owns, you have to run there manually or wait for your 'respawn' timer to run out so you can ress yourself manually. During that 2minutes you are dead, you could be useful and helping your team with the battleground goal, but instead you are stubborn a.f and wait for your 2minute ress.

[Gnurg]

How can it be abused? You are dead, opposite faction steals your graveyard, instead of getting automatically(how it should be) teleported to the nearest graveyard your faction owns, you have to run there manually or wait for your 'respawn' timer to run out so you can ress yourself manually. During that 2minutes you are dead, you could be useful and helping your team with the battleground goal, but instead you are stubborn a.f and wait for your 2minute ress.

The only way I can see it being 'abused' is if you as a ghost walk a bit over half of the way to next graveyard and use the command. That way only have to walk half the way, but I don't see why that would be very beneficial for you compared to just resurrecting on your current graveyard. =P

On the other hand, Liran might have misunderstood the suggestion, considering he still thinks it can be used outside battlegrounds.

[Kniteknite]

+Juan~ gy can get taken, and then its a foot race to another controlled gy , that might be captured as well, having to run dead from farm to start area would not be fun ~ or if possible tweak it so one ports to controlled gy , instead of ino purgatory.

[Gnurg]

Bump for visibility. Even in EotS it doesn't always work.

[Rohit]

+1
I think we had it on Spermik as well. It was really helpful. We need it here as well.

[Gnurg]

I implemented the function locally in cs_misc.cpp (had to include battleground.h) and tested it. Worked according to the first post.

Considering the majority is in favour of this command, could a staff member take a verdict on whenever we want this implemented or not? The command handler is done, so you just have to add it to a command table. I would prefer if syntax was: .gy

Code: Select all

static bool HandleGraveyardCommand(ChatHandler* handler, char const* /* args */ )

{

	

	Player* player = handler->GetSession()->GetPlayer();

	if (!player)

		return false;



	if (!player->InBattleground()) {	

		handler->SendSysMessage("Graveyard can only be used in battlegrounds.");

		handler->SetSentErrorMessage(true);

		return false;

	}

	

	if (!player->isDead()) {

		handler->SendSysMessage("Graveyard can only be used while dead.");

		handler->SetSentErrorMessage(true);

		return false;

	}

	

	if (Battleground * bg = player->GetBattleground()) {

		if (WorldSafeLocsEntry const* closestGrave = bg->GetClosestGraveYard(player)) {

			player->TeleportTo(bg->GetMapId(), closestGrave->x, closestGrave->y, closestGrave->z, player->GetOrientation());

		}

	}

	

	return true;

}

[Wilcox]

something similar to this exists on retail already, by a button on the center top of your screen while you're dead. so yeah, it does increase quality of life, supported

[adiba]

+1